Use separate config files for unique spacecraft IDs in CI builds #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert ComCfg.fpp to template (ComCfg.fpp.in) - Add CMake option FPRIME_SPACECRAFT_ID (default 0x0044) - Configure ComCfg.fpp generation from template - Update CI to use spacecraft ID 0x00C1 - Add documentation for spacecraft ID configuration Co-authored-by: Mikefly123 <[email protected]>
Co-authored-by: Mikefly123 <[email protected]>
Copilot
AI
changed the title
[WIP] Use unique space craft ID for CI machines
Add configurable spacecraft ID for CI builds
Oct 29, 2025
Copilot finished work on behalf of
Mikefly123
October 29, 2025 23:20
|
Instead create 2 ccsds file, if building in CI then sources += |
- Create ComCfg.CI.fpp for CI builds (spacecraft ID 0x00C1) - Keep ComCfg.fpp for development builds (spacecraft ID 0x0044) - Update CMakeLists.txt to select config based on CI env var - Remove template-based approach (ComCfg.fpp.in) - Simplify build process - no CMake options needed Co-authored-by: Mikefly123 <[email protected]>
Implemented your suggestion in commit dfd62b9. Now using two separate config files (ComCfg.fpp for dev, ComCfg.CI.fpp for CI) with conditional selection in CMakeLists.txt based on the CI environment variable. This is simpler and more maintainable than the template approach.
Done in commit dfd62b9. The new approach uses separate static config files instead of CMake template generation, which tightens the CI process by:
|
Copilot
AI
changed the title
Add configurable spacecraft ID for CI builds
Use separate config files for unique spacecraft IDs in CI builds
Nov 5, 2025
Copilot finished work on behalf of
Mikefly123
November 5, 2025 16:50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI machines need unique spacecraft IDs to prevent command conflicts with development devices in shared lab environments.
Implementation
ComCfg.CI.fppfor CI builds (spacecraft ID0x00C1) and keptComCfg.fppfor development builds (spacecraft ID0x0044)CIenvironment variableBenefits
.fppconfiguration filesHow It Works
The build system automatically detects the environment via the
CIenvironment variable:CIis set) → usesComCfg.CI.fpp(spacecraft ID0x00C1)ComCfg.fpp(spacecraft ID0x0044)No additional build flags needed - it works automatically.
Development builds:
0x0044(68)CI builds:
0x00C1(193)Valid range: 10-bit CCSDS spacecraft ID (
0x0000-0x03FF)Original prompt
<issue_description>To prevent conflicting commanding from test devices in labs. Use a unique space craft ID for CI builds
proves-core-reference/FprimeZephyrReference/project/config/ComCfg.fpp
Line 18 in 1d53de9
Comments on the Issue (you are @copilot in this section)
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.